Do not swallow error response #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
reviewed
Jul 13, 2023
| @@ -118,7 +118,7 @@ impl BlockingClient { | |||
|
|
|||
| match resp { | |||
| Ok(resp) => Ok(resp.into_json()?), | |||
| Err(ureq::Error::Status(code, _)) => Err(Error::HttpResponse(code)), | |||
There was a problem hiding this comment.
It would be nice to keep this as Error::HttpResponse but augment the error variant with a message: '&static str or similar field, which should also be filled in the the async/reqwest counterpart.
vladimirfomene
force-pushed
the
return-error-issue#47
branch
4 times, most recently
from
7e9b436 to
bb150e1
Compare
vladimirfomene
force-pushed
the
return-error-issue#47
branch
18 times, most recently
from
8843adf to
bf11848
Compare
vladimirfomene
force-pushed
the
return-error-issue#47
branch
from
bf11848 to
3502ba4
Compare
vladimirfomene
force-pushed
the
return-error-issue#47
branch
from
3502ba4 to
c4f53ae
Compare
|
@remix75 , @tnull and @notmandatory this is ready for review. |
notmandatory
approved these changes
Jul 25, 2023
Comment on lines
+54
to
+58
| cargo update -p log --precise 0.4.18 && | ||
| cargo update -p rustls:0.21.5 --precise 0.21.1 && | ||
| cargo update -p time:0.3.15 --precise 0.3.13 && | ||
| cargo update -p hyper-rustls:0.24.1 --precise 0.24.0 && | ||
| cargo update -p tempfile:3.7.0 --precise 3.6.0 |
There was a problem hiding this comment.
The && aren't needed when put on new lines like this.
Suggested change
| cargo update -p log --precise 0.4.18 && | |
| cargo update -p rustls:0.21.5 --precise 0.21.1 && | |
| cargo update -p time:0.3.15 --precise 0.3.13 && | |
| cargo update -p hyper-rustls:0.24.1 --precise 0.24.0 && | |
| cargo update -p tempfile:3.7.0 --precise 3.6.0 | |
| cargo update -p log --precise 0.4.18 | |
| cargo update -p rustls:0.21.5 --precise 0.21.1 | |
| cargo update -p time:0.3.15 --precise 0.3.13 | |
| cargo update -p hyper-rustls:0.24.1 --precise 0.24.0 | |
| cargo update -p tempfile:3.7.0 --precise 3.6.0 |
tnull
reviewed
Jul 26, 2023
|
I'm going to close this, the requested changes have been implemented in #58. |
Pull Request Test Coverage Report for Build 5534983433Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 5619546090Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick fix for issue #47