feat(client): add async and blocking clients to submit txs package #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikDeSmedt
suggested changes
Jan 22, 2025
src/api.rs
Outdated
|
|
||
| #[derive(Deserialize, Debug)] | ||
| pub struct MempoolFeesSubmitPackage { | ||
| pub base: f64, |
There was a problem hiding this comment.
What is base here?
Can you leave a comment
stevenroose
reviewed
Jan 22, 2025
There was a problem hiding this comment.
looks good, let just some nits. can confirm that the calls match the endpoint added in my pr on esplora (Blockstream/electrs#119)
acidbunny21
force-pushed
the
submit-tx-pkg-clients
branch
from
9f5a8f6 to
6a22216
Compare
acidbunny21
force-pushed
the
submit-tx-pkg-clients
branch
from
6a22216 to
01fb9c9
Compare
Pull Request Test Coverage Report for Build 12930470174Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart PR for Blockstream/electrs#119 to enable submitpackage API