depends: Avoid using the -ffile-prefix-map compiler option
#31800
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-ffile-prefix-map` compiler option implicitly enables `-fprofile-prefix-map` in GCC or `-fcoverage-prefix-map` in Clang, which can cause issues with coverage builds. This change ensures that only the options necessary for build reproducibility are applied.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31800. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
My Guix build: UPD. Same hashes for |
|
Tested ACK 407062f. The oss-fuzz coverage build failure described in #31770 that I am able to reproduce locally does not happen on this branch. Steps to reproduce# setup
git clone --depth 1 https://github.com/google/oss-fuzz.git
git clone https://github.com/bitcoin/bitcoin oss-fuzz/bitcoin
git clone --depth 1 https://github.com/bitcoin-core/qa-assets oss-fuzz/bitcoin/assets
cd oss-fuzz
python infra/helper.py build_image bitcoin-core
# check out master and run fuzz coverage
cd bitcoin && git switch master && cd ..
python infra/helper.py build_fuzzers --sanitizer coverage bitcoin-core bitcoin/
python infra/helper.py coverage bitcoin-core --fuzz-target psbt # fails
# check out branch and run fuzz coverage
cd bitcoin && git fetch origin pull/31800/head:31800 && git checkout 407062f2ac93624f350e9e8a4f641c882a2aaf2f && cd ..
python infra/helper.py build_fuzzers --sanitizer coverage bitcoin-core bitcoin/
python infra/helper.py coverage bitcoin-core --fuzz-target psbt # succeeds |
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to #31337 and applies analogous changes to all dependency packages.
The issue was recently noticed when
-ffile-prefix-mapwas added to thelibeventpackage, which is built in OSS-Fuzz.This PR replaces
-ffile-prefix-mapin all packages for consistency.Fixes #31770.