allow configuring the default untagged VLAN for ports #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using unbridged, untagged ports at the same time as VID 1 as default PVID on a bridge may cause unexpected leakage and forwarding of traffic. Moving to the reserved VID 4095 would avoid this, but we cannot unconditionally use it until we solved #414, as otherwise we would leak packets with VID 4095. So for now allow changing the VID used internally for ports, but keep the default at 1. Signed-off-by: Jonas Gorski <[email protected]>
rubensfig
reviewed
May 7, 2024
|
Tested the patch, and seems to be working as expected. Some concerns, however. Like mentioned in the other comment, this significantly raises (IMO) the bar for a misconfiguration between this parameter and systemd-network. Maybe its more implementation work, but don't we have the state of the swbridge in the cache/ can't we query Linux for the VLAN untagged state? |
rubensfig
approved these changes
May 7, 2024
|
LGTM, all discussions resolved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using unbridged, untagged ports at the same time as VID 1 as default PVID on a bridge may cause unexpected leakage and forwarding of traffic.
Moving to the reserved VID 4095 would avoid this, but we cannot unconditionally use it until we solved #414, as otherwise we would leak packets with VID 4095.
So for now allow changing the VID used internally for ports, but keep the default at 1.