Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New provider: athribonc #1384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nalikapalayoor
Copy link
Contributor

This PR adds a new TAIR identifier: 'athribonc'
https://pubmed.ncbi.nlm.nih.gov/39689042/

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.65%. Comparing base (8950e70) to head (7be2882).
Report is 293 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   42.51%   46.65%   +4.14%     
==========================================
  Files         117      118       +1     
  Lines        8327     8322       -5     
  Branches     1963     1359     -604     
==========================================
+ Hits         3540     3883     +343     
+ Misses       4582     4242     -340     
+ Partials      205      197       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"year": 2024
}
],
"uri_format": "https://bis.zju.edu.cn/athribonc/miRNA/AT5G07875"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"uri_format": "https://bis.zju.edu.cn/athribonc/miRNA/AT5G07875"
"uri_format": "https://bis.zju.edu.cn/athribonc/miRNA/$1"

@bgyori
Copy link
Contributor

bgyori commented Jan 28, 2025

I realize this is actually problematic because technically AT5G07875 is a TAIR locus name, not an identifier (called "TAIR Accession" in their terminology), and the current tair.locus (similar to other subprefixes for tair) is defined for identifiers like 6532565372. There is generally a complicated situation surrounding TAIR identifiers and their resolution, as noted in #1335, so whether we want to add this or not requires a bit more thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants