Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#108
This adds a new action to the dropdown of the downloaded models in the ModelList of the bioimage.io widget. In essence, it retrieves the doi from the downloaded rdf spec, spawns the predictor function as shown in this notebook, and wraps it with magicgui in a separate predictor widget.
I started working on this at the ome-ngff-Hackathon at the biovisioncenter last week and would be happy for some feedback on it.
Minor thoughts:
predict_image
functions checks under the hood whether the image dimensions line up with what the model expects - including some singleton dimensions. I don't think a prediction should fail if a model expects, say,[1x1xZxYxX]
and receives[ZxYxX]
. Maybe missing singleton dimensions could be added under the hood?yield
statement to allow for threaded execution.@lorenzocerrone @jdeschamps could be interesting for you? Would be interested in your thoughts - I will leave this as draft PR for now.