Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: move ipython/repl functionality to optional dependency group #163

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Jun 13, 2024

close #147

Per brief discussion on a biocommons call the other day -- this PR moves the dependency (ipython) required for shell functionality to an optional group and adds a bit of information to the ImportError if ipython is unavailable.

I would expect this to impact a pretty small number of users, but it is a breaking change.

@jsstevenson jsstevenson requested a review from reece June 13, 2024 15:19
@jsstevenson jsstevenson requested a review from a team as a code owner June 13, 2024 15:19
@reece reece changed the base branch from main to develop July 5, 2024 13:54
Copy link
Member

@reece reece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for implementing.

@reece reece merged commit 373b0c3 into develop Jul 5, 2024
5 checks passed
@reece reece deleted the 147-ipython-optional branch July 5, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPython dependency -- remove it or make it optional
3 participants