-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring recomendations #40
base: dynamodb/operations/executor
Are you sure you want to change the base?
Refactoring recomendations #40
Conversation
Conflicts: src/main/scala/com/bio4j/dynamograph/model/go/TableGoSchema.scala
updated this to Properties everywhere |
@eparejatobes Thanks for update; Yes I even notice that you introduce some changes and publish them :) - now I have some problems because after update those libraries I have more or less 100 compilation errors (looks like problem with caches) - I will fix those problems and work on docs |
Hello @eparejatobes How is going with changes in scarp, type-sets and tabula? It is ready? How is your neck? I hope you get better today. |
much better thanks! I think you can start using all of them :) let me check out this and see how things are |
Great. |
hey @alberskib I got caught in a meeting and I just did something like what you did 👍 |
I'll comment on what I think can be done simpler |
Great - It still needs some work but every comment that makes code better is more than welcome :) |
nice @alberskib just some details :) |
…raph into refactoring/recomendations
@eparejatobes Could you tell me how to convert item to the record? |
You mean from |
Exactly |
IIRC |
Hi @alberskib!
I just made some changes and left notes (sometimes questions). You can leave comments on the commit. Most of what I've done here is quite superficial refactoring. Maybe I don't get something and my changes are not suitable — just tell me.