-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump transformers and accelerate versions #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, LGTM!
src/petals/__init__.py
Outdated
assert ( | ||
version.parse("4.32.0") <= version.parse(transformers.__version__) < version.parse("4.35.0") | ||
), "Please install a proper transformers version: pip install transformers>=4.32.0,<4.35.0" | ||
# assert ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix this?
todo:
|
src/petals/__init__.py
Outdated
assert ( | ||
version.parse("4.32.0") <= version.parse(transformers.__version__) < version.parse("4.35.0") | ||
), "Please install a proper transformers version: pip install transformers>=4.32.0,<4.35.0" | ||
version.parse(transformers.__version__) == version.parse("4.37.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we can safely support up to 4.38.0 (not including that). Can we make it
4.37.1 <= version < 4.38.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM! Please reflect "removed falcon-rw-1b CI tests" in the squashed commit description.
This PR bumps versions for the following dependecies:
and removes falcon-rw-1b CI tests