Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: exemplary annotation of three MSI datasets #450

Closed
wants to merge 7 commits into from

Conversation

foellmelanie
Copy link
Contributor

this is hopefully a starting point to discuss how MSI datasets can be represented in the format

@foellmelanie
Copy link
Contributor Author

mh...comment[cleavage agent details] is mandatory but does not accept "not applicable", how could this be solved?

@foellmelanie
Copy link
Contributor Author

The latest Bruker instruments (rapifleX, timsTOF fleX) used for MSI are not available in the ontology:
https://www.ebi.ac.uk/ols/ontologies/ms/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FMS_1000031&viewMode=All&siblings=false

@ypriverol
Copy link
Member

@foellmelanie can you change the PR add some of the ideas in the #451 into the specification. I mean, would be really nice to review the example, plus the specification in the PR to have both updated.

@ypriverol ypriverol linked an issue Sep 22, 2020 that may be closed by this pull request
@ypriverol ypriverol self-requested a review September 22, 2020 08:58
@ypriverol
Copy link
Member

@foellmelanie I have created an issue #454 to make the not applicable the enzyme. When you make the modifications to the specification can you add a sentence to https://github.com/bigbio/proteomics-metadata-standard/tree/master/sample-metadata#42-enzyme section to make clear that is possible. We are modifying the validator accordingly.

@ypriverol
Copy link
Member

PR HUPO-PSI/psi-ms-CV#45 added the rapiplex

@foellmelanie
Copy link
Contributor Author

Thanks @ypriverol for adding rapiflex. Could you please also add the newest one timsTOF fleX

@ypriverol
Copy link
Member

@foellmelanie instrument here HUPO-PSI/psi-ms-CV#46

@ypriverol
Copy link
Member

@foellmelanie I will close this PR. We can try to recover it if we get more attention in the future.

@ypriverol ypriverol closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enzyme can be not applicable
2 participants