-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STY] fix some remark warnings #2026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What sort of errors do you get, and from which linter? The reason for the local warnings might be different versions.
jsut did the following on master and tried to use a node version close to the one used in CI $ nvm install 22
$ node --version
v22.13.0
$ npm --version
10.9.2
$ npm install `cat npm-requirements.txt`
$ npx remark src/**/*.md --frail --rc-path .remarkrc
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2026 +/- ##
=======================================
Coverage 82.45% 82.45%
=======================================
Files 17 17
Lines 1499 1499
=======================================
Hits 1236 1236
Misses 263 263 ☔ View full report in Codecov by Sentry. |
I was getting those locally.
Not sure why they are not caught in CI.