-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] allow using of mkdoc admonitions #1711
Conversation
Remi-Gau
commented
Feb 23, 2024
•
edited
Loading
edited
- add a script to remove mkdoc admonitions
- run it during pdf build
- add minimal testing to help debugging if needed
- add example admonition to highlight the bids examples repo
@@ -679,33 +681,38 @@ def process_macros(duplicated_src_dir_path): | |||
|
|||
duplicated_src_dir_path = "src_copy/src" | |||
|
|||
# Step 1: make a copy of the src directory in the current directory | |||
# make a copy of the src directory in the current directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the step ordering... Because we will have to change it everytime steps are added.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1711 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
@tsalo @sappelhoff @effigies Can you have a quick look and tell me if you see something I am missing? |
the remark linting will be annoying though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot @Remi-Gau, I think this looks promising and can be deployed.
the remark linting will be annoying though
an easy fix would be to switch off that particular linting check, which I think would be fine.
OK so it seems that remark-lint-code-block-style is set to So need to find how to unset that. |
This looks awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is not run automatically in CI.
PDF looks fine to me. Note that some links are not rendered in the pdf but this is not related to this PR. For example the link at the top of the genetic section:
I think this is because of the back tick in the square brackets. |
For contributors: should we preface our admonitions with some markdown comments the way we do it the macros so that users are not confused about what they are ? |
I don't think that's necessary. Macros aren't exactly common, but admonitions are. We can have that info in a style guide if we want though. |
OK so something to add in the contributing.md |
Actually before merging.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!