Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internetarchive.cli.argparser renamed to internetarchive.cli.cli_utils in v5+ of internetarchive #341

Closed
wants to merge 3 commits into from

Conversation

jjjake
Copy link
Collaborator

@jjjake jjjake commented Nov 13, 2024

No description provided.

@vxbinaca
Copy link
Collaborator

Please see #339 and compare your changes to hers. I can version lock to want 5.0.3 and beyond if you'd like, actually I would like this and may implement anyway.

@jjjake
Copy link
Collaborator Author

jjjake commented Nov 13, 2024

I'll let you do whatever you think is best @vxbinaca. I can see where having your own function, as added in #339, could be nice (e.g. avoid compatibility issues in the future (not that I'm planning on any breaking changes here!)).

I'll resolve the conflict, but feel free to close this MR and go whichever way you think is best.

Thanks again!

@vxbinaca
Copy link
Collaborator

vxbinaca commented Nov 13, 2024

I'll let you do whatever you think is best @vxbinaca. I can see where having your own function, as added in #339, could be nice (e.g. avoid compatibility issues in the future (not that I'm planning on any breaking changes here!)).

I'll resolve the conflict, but feel free to close this MR and go whichever way you think is best.

Thanks again!

You guys are updating the UI, and when we pushed the change my fresh test item isn't rendering text I need to figure out what if this is because y'all are changing the UI or if that code we just merged is bugged.

https://archive.org/details/twitch-vod-v2300692592

image

@vxbinaca
Copy link
Collaborator

it's the UI, disregard, it just came at a really inopportune time it literally started as soon as we cut a new version

@vxbinaca
Copy link
Collaborator

vxbinaca commented Dec 5, 2024

Closing because we merged someone elses change that did the same thing, thanks @jjjake great to hear from your again.

@vxbinaca vxbinaca closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants