Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ESLint keeping only Biome #552

Merged
merged 1 commit into from
Feb 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .eslintignore

This file was deleted.

19 changes: 0 additions & 19 deletions .eslintrc

This file was deleted.

7 changes: 4 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Fork and clone the repository and run in the root:
npm install
```

Type definitions are generated automatically after install, VS Code should be able to find the new files but if it complains about missing types just open the command palette and typ: "TypeScript: Restart TS Server"
Type definitions are generated automatically after install, VS Code should be able to find the new files but if it complains about missing types just open the command palette and type: "TypeScript: Restart TS Server"

## Working on a package

Expand All @@ -30,15 +30,16 @@ You can also run the watcher at the root level to watch all packages for changes
After you've finished making your changes, ensure there are no errors and that your code can build correctly.

```bash
# in the root run this two commands
# in the root run this commands
npm run format
npm run lint
npm run build
```

## Before you open a Pull Request

- Follow the same conding style.
- Use eslint to verify your code.
- Use biome to verify your code. `npm run format` to properly format the code and then `npm run lint`.
- **DO NOT** commit changes in the dist directory, this files are generated automatically by Github Actions.
- Follow Git best practices (especially use meaningful commit messages).
- Add a changeset (If required) specifying the packages you worked with a description
Expand Down