Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable fast options by default #81

Merged
merged 4 commits into from
Apr 9, 2021
Merged

enable fast options by default #81

merged 4 commits into from
Apr 9, 2021

Conversation

appelmar
Copy link
Member

  • Add strucchangeRcpp to Depends
  • set_default_options() -> set_fallback_options()
  • fast options are set when the package is loaded

We still might need to run roxygen again.

Copy link
Collaborator

@GreatEmerald GreatEmerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but we need to fix bfastpp first before we enable the fast options by default.

R/zzz.R Outdated Show resolved Hide resolved
bfast.use_bfastts_modifications = FALSE,
strucchange.use_armadillo=FALSE
bfast.prefer_matrix_methods = TRUE,
bfast.use_bfastts_modifications = TRUE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This depends on #19 though. And good to include a more complex test in the bfastpp examples, perhaps, that would cover regular and irregular cases.

R/zzz.R Outdated Show resolved Hide resolved
Co-authored-by: Dainius Masiliūnas <[email protected]>
@GreatEmerald GreatEmerald merged commit def30fe into master Apr 9, 2021
@GreatEmerald GreatEmerald deleted the set_options branch April 9, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants