Replace all joinsas with joinas spec #614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekingfrog
approved these changes
Mar 3, 2025
| cmd | ||
| |> String.trim() | ||
| |> String.downcase() | ||
| |> case do |
There was a problem hiding this comment.
oh, didn't know you could do |> case do that's neat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!joinasallows players to join as another player or spectator in an active games, unfortunately it has been used by some players to join as other players without their approval and sabotage them. There was code in place that was supposed to replace all!joinascommands with!cv joinaswhich would call a vote when calling the command, however this code only covered the lowercase!joinas, it could be bypassed by different word capitalisations (e.g!joinAs).These changes fix this and furthermore replace all
!joinascommand variants with!joinas spec, no longer allowing joining as another player.