Elixir upgrade 1.18 #612
Open
Elixir upgrade 1.18 #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekingfrog
force-pushed
the
elixir-upgrade-1.18
branch
from
ea22e7c to
a3a24f4
Compare
It seems this is unused, and anyway we are on one node
The jump to 4.0 is, according to the changelog, a change in default values, so we should be fine with that.
L-e-x-o-n
reviewed
Feb 28, 2025
This was removed in liveview 1.0 see: https://hexdocs.pm/phoenix_live_view/changelog.html#backwards-incompatible-changes-for-1-0
This is mostly live view stuff that is getting deprecated, so moved to the new equivalent
New version of the compiler catches more stuff yay!
geekingfrog
force-pushed
the
elixir-upgrade-1.18
branch
from
a3a24f4 to
0844f2f
Compare
Changes in heex mostly
L-e-x-o-n
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be coordinated with the merge of beyond-all-reason/ansible-teiserver#7 for the infra bits.
Probably better to give a quick test on the integration server as well. The vast majority of changes are around phoenix and liveview, so having a quick look at the different pages should be enough.
I'll upgrade otp in a different PR.