Refactor filesystem_watcher_system with let-else #7545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
added
A-Assets
nicopap
force-pushed
the
tinny-let-else-assets
branch
from
286782c to
6177704
Compare
SpecificProtagonist
approved these changes
Feb 7, 2023
|
Related: #7104 It looks like rustfmt still doesn't support |
|
Oooh, I thought #7104 was merged already and this was an oversight. Hmm, not sure if I should keep this open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
filesystem_watcher_system previously used
if letina way that could be cleanly replaced by
let else.Inside the
loop, there were amatchfollowed by aif letthat could be merged together.
Solution
Use
let elseand merge thematchandif let