Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async-broadcast requirement from 0.5 to 0.7 #11830

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 12, 2024

Updates the requirements on async-broadcast to permit the latest version.

Changelog

Sourced from async-broadcast's changelog.

Version 0.7.0

  • Breaking: Recv and Send are now !Unpin to allow for future optimizations.
  • Port to event-listener v5.0.

Version 0.6.0

  • Bump to event-listener v3.0.0.
  • Add smol-rs logo to docs.

Version 0.5.1

  • Drop parking_lot dependency, in favor of sync primitives in std.

Version 0.5.0

  • API to disable waiting for active receivers (#35).

Version 0.4.1

  • Drop unneeded easy-parallel dep.
  • Bumb dependencies to the current versions.
  • Update parking_lot to 0.12.1.
  • fix incorrect documentation for TrySendError::is_disconnected.

Version 0.4.0

  • Add RecvError::Overflowed for detecting missing messages.
  • Avoid overflows on 32- and 16-bit systems (#22).
  • Add overflow message count.
  • Clone impl of Receiver now properly duplicates it.
  • Add Receiver::new_receiver.
  • Add Receiver::new_sender and Sender::new_receiver, allowing generating senders from receivers and vice versa, respectively.
  • Switch to parking_lot::RwLock instead of std::sync::Mutex.

Version 0.3.4

  • Avoid the last clone in try_recv (#18).
  • Add some basic benchmarks.

Version 0.3.3

  • Close channel if the last receiver to drop is inactive.

Version 0.3.2

  • Fix a underflow panic (#14).
  • Document difference with other broadcast APIs.

... (truncated)

Commits
  • 1803434 Merge pull request #53 from zeenix/release-0.7
  • 1833f3d Release 0.7.0
  • ab8a1eb Merge pull request #48 from smol-rs/notgull/evl5
  • 3c45a87 breaking: Make futures !Unpin
  • 1308d61 chore: Review comments
  • 7ed60db chore: Use released event-listener
  • 669f0e4 Port to event-listener v5.0
  • c2ec71e Merge pull request #49 from smol-rs/taiki-e/checkout
  • b6a8072 Update actions/checkout action to v4
  • 92adf87 Merge pull request #46 from zeenix/release-0.6
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the C-Dependencies A change to the crates that Bevy depends on label Feb 12, 2024
@dependabot dependabot bot force-pushed the dependabot/cargo/async-broadcast-0.7 branch from e77777f to 84fdcbc Compare February 17, 2024 09:41
@james7132
Copy link
Member

This continues to be broken on wasm. This issue may need to be upstreamed.

@james7132 james7132 added the S-Blocked This cannot move forward until something else changes label Feb 19, 2024
@james7132
Copy link
Member

Looks like it's already been reported: smol-rs/async-broadcast#50

Updates the requirements on [async-broadcast](https://github.com/smol-rs/async-broadcast) to permit the latest version.
- [Changelog](https://github.com/smol-rs/async-broadcast/blob/master/CHANGELOG.md)
- [Commits](smol-rs/async-broadcast@0.5.0...0.7.0)

---
updated-dependencies:
- dependency-name: async-broadcast
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/async-broadcast-0.7 branch from 84fdcbc to 1429d92 Compare February 21, 2024 21:18
@mnmaita
Copy link
Member

mnmaita commented May 20, 2024

Looks like this might be addressed by smol-rs/async-broadcast#59

@mnmaita
Copy link
Member

mnmaita commented Jun 11, 2024

Checked some recent updates in async-broadcast and I think this change fixes WASM builds.

Maybe we can close this issue and let dependabot pick the next version whenever it comes out.

@rparrett
Copy link
Contributor

Done in #17500

@rparrett rparrett closed this Jan 23, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 23, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/async-broadcast-0.7 branch January 23, 2025 05:27
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
# Objective

Dependabot tried up update this earlier, but it was noticed that this
broke wasm builds. A new release has happened since then which includes
a fix for that.

Here's the
[changelog](https://github.com/smol-rs/async-broadcast/blob/master/CHANGELOG.md).

Closes #11830

## Solution

Use `async-broadcast` `0.7.2`.

## Testing

I ran a few some examples involving assets on macos / wasm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Dependencies A change to the crates that Bevy depends on S-Blocked This cannot move forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants