-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update async-broadcast requirement from 0.5 to 0.7 #11830
Conversation
e77777f
to
84fdcbc
Compare
This continues to be broken on wasm. This issue may need to be upstreamed. |
Looks like it's already been reported: smol-rs/async-broadcast#50 |
Updates the requirements on [async-broadcast](https://github.com/smol-rs/async-broadcast) to permit the latest version. - [Changelog](https://github.com/smol-rs/async-broadcast/blob/master/CHANGELOG.md) - [Commits](smol-rs/async-broadcast@0.5.0...0.7.0) --- updated-dependencies: - dependency-name: async-broadcast dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
84fdcbc
to
1429d92
Compare
Looks like this might be addressed by smol-rs/async-broadcast#59 |
Checked some recent updates in Maybe we can close this issue and let dependabot pick the next version whenever it comes out. |
Done in #17500 |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
# Objective Dependabot tried up update this earlier, but it was noticed that this broke wasm builds. A new release has happened since then which includes a fix for that. Here's the [changelog](https://github.com/smol-rs/async-broadcast/blob/master/CHANGELOG.md). Closes #11830 ## Solution Use `async-broadcast` `0.7.2`. ## Testing I ran a few some examples involving assets on macos / wasm.
Updates the requirements on async-broadcast to permit the latest version.
Changelog
Sourced from async-broadcast's changelog.
... (truncated)
Commits
1803434
Merge pull request #53 from zeenix/release-0.71833f3d
Release 0.7.0ab8a1eb
Merge pull request #48 from smol-rs/notgull/evl53c45a87
breaking: Make futures !Unpin1308d61
chore: Review comments7ed60db
chore: Use released event-listener669f0e4
Port to event-listener v5.0c2ec71e
Merge pull request #49 from smol-rs/taiki-e/checkoutb6a8072
Update actions/checkout action to v492adf87
Merge pull request #46 from zeenix/release-0.6You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)