Fixed bug where jobs added to the board while running were not displayed

beverlyRoadGoose · Aug 12, 2019 · ea93cef · ea93cef
1 parent 6c7a92d
commit ea93cef
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## Change Log
 
+#### v0.2.0-beta.4
+- Fixed bug where jobs added to the board while running were not displayed
+
 ##### v0.1.3-beta.3 ~ 2019.08.06
 - Corrected build version in build properties file
 

diff --git a/src/main/webapp/src/components/board/MonitoredJob.vue b/src/main/webapp/src/components/board/MonitoredJob.vue
@@ -155,6 +155,10 @@
         return this.jobData.latestRun !== null;
       },
 
+      jobHasACompleteRun: function () {
+        return this.jobData.lastCompleteRun !== null;
+      },
+
       jobIsRunning: function () {
         return this.jobHasBeenRun() && this.jobData.latestRun.isRunning;
       },
@@ -175,6 +179,10 @@
       },
 
       getProgressBarColor: function () {
+        if (!this.jobHasACompleteRun()) {
+          return '#ababab';
+        }
+
         switch (this.jobData.lastCompleteRun.result.name) {
           case 'SUCCESS': return '#98d398';
           case 'FAILURE': return '#ff7d77';
@@ -184,6 +192,10 @@
       },
 
       getProgressBarBlinkClass: function () {
+        if (!this.jobHasACompleteRun()) {
+          return 'blink-grey';
+        }
+
         switch (this.jobData.lastCompleteRun.result.name) {
           case 'SUCCESS': return 'blink-green';
           case 'FAILURE': return 'blink-red';