Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(print_mffc): Missing condition when single output linked to CO #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wjrforcyber
Copy link
Contributor

Bug

print_mffc can't print some simple examples.

Minimum Reproducible Example (MRE)

Given aig

aag 5 3 0 1 2
2
4
6
10
8 2 4
10 8 6

which looks like:
Screenshot 2025-01-17 at 18 20 48

run abc with following commands:

./abc -c "read_aiger noreconv.aig; ps; print_mffc"
ABC command line: "read_aiger noreconv.aig; ps; print_mffc".

noreconv                      : i/o =    3/    1  lat =    0  and =      2  lev =  2

No mffc statistic is printed.

Analysis

The condition only considers dag node while missing the case when the node is a tree node but directly connected to PO.

Fix

After adding the corner case condition, the result will show the mffc in the circle.


./abc -c "read_aiger noreconv.aig; ps; print_mffc"
ABC command line: "read_aiger noreconv.aig; ps; print_mffc".

noreconv                      : i/o =    3/    1  lat =    0  and =      2  lev =  2
Node =     n6 : Supp =   3  Cone =   2  ( n5 n6 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant