Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(generics): Remove Generics from Node Builder #2500

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

rezbera
Copy link
Contributor

@rezbera rezbera commented Feb 10, 2025

Cleans up the generics from the node building process which was an eyesore

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 32.24%. Comparing base (558c903) to head (95d7424).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/builder/options.go 0.00% 8 Missing ⚠️
cli/builder/builder.go 0.00% 5 Missing ⚠️
cmd/beacond/main.go 0.00% 5 Missing ⚠️
node-core/builder/builder.go 0.00% 4 Missing ⚠️
node-core/builder/options.go 0.00% 2 Missing ⚠️
cli/commands/setup.go 0.00% 1 Missing ⚠️
consensus/cometbft/cli/commands.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   32.24%   32.24%           
=======================================
  Files         350      350           
  Lines       15653    15653           
  Branches       20       20           
=======================================
  Hits         5047     5047           
  Misses      10243    10243           
  Partials      363      363           
Files with missing lines Coverage Δ
cli/commands/server/rollback.go 0.00% <ø> (ø)
cli/commands/server/start.go 0.00% <ø> (ø)
cli/commands/setup.go 0.00% <0.00%> (ø)
consensus/cometbft/cli/commands.go 0.00% <0.00%> (ø)
node-core/builder/options.go 0.00% <0.00%> (ø)
node-core/builder/builder.go 0.00% <0.00%> (ø)
cli/builder/builder.go 0.00% <0.00%> (ø)
cmd/beacond/main.go 0.00% <0.00%> (ø)
cli/builder/options.go 0.00% <0.00%> (ø)

@rezbera rezbera marked this pull request as ready for review February 10, 2025 03:00
@rezbera rezbera requested a review from a team as a code owner February 10, 2025 03:00
@rezbera rezbera requested a review from a team February 10, 2025 03:00
Copy link
Contributor

@fridrik01 fridrik01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rezbera rezbera merged commit 412f08e into main Feb 10, 2025
19 checks passed
@rezbera rezbera deleted the clean-nodebuilder-generics branch February 10, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants