Reintroduce JRuby 9.4 to testing matrix #1559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRuby won't work with 8.0 and head anyways Tests will take time, doing it once for one rails version seems ok to me.
I thought it would take the one value from the matrix
|
Made some tweak since it would definitly fail the way you had it beforehand. JRuby only supports Ruby 3.1 syntax so anything after Rails 7.2 would 100% not work. Up to you if you want to run different Rails versions for JRuby, I have it only on 7.2 now. I think that is fine? But maybe you think otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in #1391
Pending JRuby 9.4.10 release