Skip to content

Commit

Permalink
Fix passing a block to advisory_lock in tests (#1587)
Browse files Browse the repository at this point in the history
This method does not take a block. As such, the expectation is never executed
  • Loading branch information
Earlopain authored Jan 26, 2025
1 parent b6cbd53 commit 348fc1d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions spec/app/models/concerns/good_job/advisory_lockable_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -483,9 +483,8 @@

it "locks and unlocks" do
GoodJob::Job.transaction do
job.advisory_lock(function: "pg_advisory_xact_lock") do
expect(job.advisory_locked?).to be true
end
job.advisory_lock(function: "pg_advisory_xact_lock")
expect(job.advisory_locked?).to be true
end
expect(job.advisory_locked?).to be false
end
Expand Down

0 comments on commit 348fc1d

Please sign in to comment.