reworked AudioBuffer #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 83dc7d7)
|
Hi, Thanks for improving RPlay! However, there seems to be a problem with your code. It looks like "audioBuffer[i]" returns null. |
|
i have made some other changes...maybe i forgot to copy something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i tested RPlay on the Raspberry pi and noticed that the Audiobuffer was a common source for failure.
The problem was related to how the Audiobuffer calculated the buffered elements to restart getNextFrame() after an underrun. Also the performance was not very good because of some inefficient locks.
I also entangled the Source code a bit and converted the AudioData to a "right" class instead of some proved C construct.
It now performs much better on the raspberry pi. :)