Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop OpenAPI 2.0 support, enable validator and dependabot #15

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

jpraet
Copy link
Contributor

@jpraet jpraet commented Jan 27, 2025

  • Drop OpenAPI 2.0 support
  • Enable belgif-rest-guide-validator-maven-plugin
  • Enable dependabot for automatic github-actions and maven upgrades
  • Upgrade maven plugin dependencies
  • Use string for "${project.version}"

* Drop OpenAPI 2.0 support
* Enable belgif-rest-guide-validator-maven-plugin
* Enable dependabot for automatic github-actions and maven upgrades
* Upgrade maven plugin dependencies
* Use string for "${project.version}"
@jpraet jpraet requested a review from pvdbosch January 27, 2025 09:47
@jpraet
Copy link
Contributor Author

jpraet commented Jan 27, 2025

@pvdbosch once this PR has been reviewed and merged, I'll do the same for the other repo's (maybe without asking a review, as those changes will be more or less identical to this PR).

@pvdbosch
Copy link
Contributor

LGTM, to be coordinated with the update of https://github.com/belgif/workflows/blob/main/.github/workflows/openapi-release-workflow.yml then.

About the dependabot file: could auto-merge be configured when the PR build succeeds? Otherwise it'll become cumbersome to manage all PRs for all openapi repos.
Too bad there doesn't seem to be a way to have a shared dependabot config across repos...

@jpraet
Copy link
Contributor Author

jpraet commented Jan 27, 2025

LGTM, to be coordinated with the update of https://github.com/belgif/workflows/blob/main/.github/workflows/openapi-release-workflow.yml then.

OK if I update that one already? Any plans to release any openapi-* in the near term?

About the dependabot file: could auto-merge be configured when the PR build succeeds? Otherwise it'll become cumbersome to manage all PRs for all openapi repos.

There are some third party actions for that, or we can create the dependabot auto-merge workflow ourselves based on this official documentation.

Too bad there doesn't seem to be a way to have a shared dependabot config across repos...

Indeed, can't seem to find anything about that either.

@pvdbosch
Copy link
Contributor

OK if I update that one already? Any plans to release any openapi-* in the near term?

OK, no new releases are planned in the near future

About the dependabot file: could auto-merge be configured when the PR build succeeds? Otherwise it'll become cumbersome to manage all PRs for all openapi repos.

There are some third party actions for that, or we can create the dependabot auto-merge workflow ourselves based on this official documentation.

OK, one of those options should do! A bit more work than for Renovate, it seems.

@jpraet jpraet merged commit bbe7f9b into master Jan 28, 2025
1 check passed
@jpraet jpraet deleted the feature/maintenance branch January 28, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants