Fix: dotnet test failure in CliTests.Should_Return_Error_When_No_DirectoryOrFile_And_Not_Piping_StdIn
#1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectoryOrFile_And_Not_Piping_StdIn` Problem: The test `CliTests.Should_Return_Error_When_No_DirectoryOrFile_And_Not_Piping_StdIn` was consistently failing when executed via the `dotnet test` command. This issue appears to have been caused by CliWrap, which initializes `ProcessStartInfo` with `RedirectStandardInput = true` by default. This behavior interfered with the test, as it relies on `Console.IsInputRedirected` being `false`. Solution: This patch updates the test to use `ProcessStartInfo` directly instead of relying on CliWrap. This ensures that `RedirectStandardInput` is explicitly set to `false`.
belav
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The test
CliTests.Should_Return_Error_When_No_DirectoryOrFile_And_Not_Piping_StdInwas consistently failing when executed via thedotnet testcommand.This issue appears to have been caused by CliWrap, which initializes
ProcessStartInfowithRedirectStandardInput = trueby default. This behavior interfered with the test, as it relies onConsole.IsInputRedirectedbeingfalse.Solution
This patch updates the test to use
ProcessStartInfodirectly instead of relying on CliWrap. This ensures thatRedirectStandardInputis explicitly set tofalse.