Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement CLI Commands to SubCommands #1333

Merged
merged 25 commits into from
Dec 31, 2024

Conversation

stefannikolei
Copy link
Contributor

I started working on creating subcommands.

Could I get feedback for this? Is this the direction you want it to go?

It would be good for me when we could define all commands with the possible options

@belav
Copy link
Owner

belav commented Aug 23, 2024

Could I get feedback for this? Is this the direction you want it to go?

I only had time to scan it quick, but yeah I this looks like what I was thinking, breaking apart the commands so it is clear which options apply to which command.

@stefannikolei
Copy link
Contributor Author

Ok i am finished. You could go for a review. One thing I was not sure about was which option should be available for the check command.

@stefannikolei stefannikolei changed the title Draft: Implement check as subcommand Reimplement CLI Commands to SubCommands Aug 24, 2024
Copy link
Collaborator

@shocklateboy92 shocklateboy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to let @belav do the final merge though.

Copy link
Owner

@belav belav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure what options are needed for check, I'm guessing there will be a few from format that need to be added to check. Probably these three

--no-msbuild-check
--include-generated
--compilation-errors-as-warnings

It is also possible that --no-cache would apply.

I can always merge for now and figure it out later unless you wanted to take it on in the same PR. Sorry for the delay in getting back to this, and thanks for the contribution!

@stefannikolei
Copy link
Contributor Author

As you want. You can also ping me when you figured it out.

@belav belav changed the base branch from main to 1.0.0 December 28, 2024 02:06
@belav
Copy link
Owner

belav commented Dec 31, 2024

Got the last few sub options cleaned up and settled on just making a new branch for 1.0.0 instead of waiting to merge this to main. Thanks again!

@belav belav merged commit e87fc09 into belav:1.0.0 Dec 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants