-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python to current supported versions. Also add experimental support for next python release #5503
Conversation
I've added back 3.9 and 3.10. Also I've pushed 3.12 to be ok to fail, since now it is failing. The best scenario would be to have up to 3.13 working properly, considering that 3.13 is already in Fedora 41 (released last month) and very soon other distros will move to it |
fded292
to
c0316e7
Compare
I see that you're dropping support for Python 3.8 - note that this needs a bit more effort:
That's a couple of things just off the top of my head - there's likely a couple of others. Are you happy to go ahead with the above or would you like to limit the scope of this PR to simply add support for the most recent version without removing Python 3.8? |
I've added back 3.8. The reason why I removed it in the first place was that it is EOL, but I don't mind it being there. The part I'm interested into is the support to the newest versions. I don't have anything against the old versions :). |
Deps installation on Python 3.12+ seems to be failing due to Poetry resolved this I will shortly submit a PR that removes Python 3.8 support and fixes this issue for you. |
Thanks a lot :) As soon as the other PR is merged, I'll rebase this one :) |
I think you may be able to adjust the base branch for this PR to point to |
1266c61
to
a0d1812
Compare
Thanks! I've rebased on the |
I guess we'd need to understand why is that issue occurring: if you want to try to fix it you will have to wrestle with Poetry a bit and find out why is that dependency installation failing. As far as I remember, this may have to do with |
It seems like there is an issue with |
Alternatively, you can also split this into two PRs:
|
…pport for python 3.13 and the next python release Ensure that llvm and openblas are present, seems it seems they are not in some cases.
6c879cd
to
75f2b85
Compare
I've moved the 3.13 to be ok to fail so that this can be merged. We can work on 3.13 support when Thanks a lot :) |
I bet that numba will get fixed before #5508 is reviewed and ready to merge 😁 I think that's the main bottleneck here. |
- Drop support for EOL Python 3.8 making Python 3.9 the minimum supported version - Take advantage of Python 3.9+ type hint syntax by: - Using `list[T]` instead of `List[T]` etc. from typing module - Using `Type | None` syntax for unions instead of `Union[Type, None]` - Moving collection type hints from `typing` to `collections.abc` - Using `TYPE_CHECKING` guard for runtime import optimization Note: in #5503 we found that we cannot support Python 3.12 unless we upgrade our minimum support Python to 3.9.
Oh I stupidly removed the Apologies!! |
Description
Bump python version in the CI to current versions.