Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartplaylist: add extm3u/extinf/m3u8 support #5046

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

mgoltzsche
Copy link
Contributor

@mgoltzsche mgoltzsche commented Dec 13, 2023

Description

Adds the boolean configuration option smartplaylist.extm3u to allow generating extm3u playlists that contain additional information (artist, title, length) per track. See Extended M3U (Wikipedia) and playlist specification for HTTP Live Streaming (RFC8216).
This is to be able to display meaningful metadata and search tracks within a playlist within a player without having to load the linked audio files of that playlist.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@mgoltzsche mgoltzsche marked this pull request as draft December 13, 2023 20:05
@mgoltzsche mgoltzsche force-pushed the add-extinf-support branch 25 times, most recently from 980a512 to 7a7fc88 Compare December 14, 2023 00:19
@mgoltzsche mgoltzsche marked this pull request as ready for review December 14, 2023 00:32
This is to be able to display meaningful metadata and search a playlist within a player without having to load the linked audio files of a playlist.
@Serene-Arc
Copy link
Contributor

Thanks! This is a very useful change, and it all looks good to me.

@Serene-Arc Serene-Arc merged commit 60ad1ba into beetbox:master Dec 14, 2023
13 checks passed
@mgoltzsche
Copy link
Contributor Author

mgoltzsche commented Dec 15, 2023

I realize it is disadvantageous to chose a boolean flag to specify the format because we may as well want to specify JSON as playlist output format at some point.
Thus, do you mind if I create another PR to change the newly added flag (before it is released) to --format (or so) and make it of type=string to let users specify --format=m3u|m3u8?

@Serene-Arc
Copy link
Contributor

Sure! Go right ahead.

@mgoltzsche
Copy link
Contributor Author

mgoltzsche commented Dec 15, 2023

Okay, I created #5053 now to change the option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants