Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert line change behaviour when importing tracks #5007

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

Serene-Arc
Copy link
Contributor

@Serene-Arc Serene-Arc commented Nov 24, 2023

Fixes #4980

When importing, the old behaviour before the UI upgrade was that changed tracks were always displayed. After the update was merged, this was changed to showing no tracks at all unless the detail configuration was enabled, in which case all tracks are shown. This changes the behaviour back to what it should be.

@Serene-Arc Serene-Arc requested a review from JOJ0 November 24, 2023 05:12
Copy link
Member

@JOJ0 JOJ0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this very essential fix! :-) Tiny suggestion within.

beets/ui/commands.py Show resolved Hide resolved
@Serene-Arc Serene-Arc merged commit c4c82e9 into beetbox:master Nov 30, 2023
13 checks passed
@Serene-Arc Serene-Arc deleted the track_change_info branch November 30, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Importer UI not showing track level changes when import.detail: false
3 participants