-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/missing schema columns #48
Conversation
Hey @awoehrl this is a great callout! As part of my work to provide support for |
Hey @awoehrl the |
…/missing_schema_columns
Hey @awoehrl - thanks for the updates! And I appreciate you adding a model to use for testing 🙏 Looks like these changes broke CI though. I'm going to pull down to my local machine to see if this issue is related to CI running on a forked branch. If that's the case, then we should be good to merge! If not, given that this is a utility function, I'd be okay with deprecating the testing and just shipping the changes to the macro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better (very) late than never... confirming the failed CI is related to secrets access. Sorry for leaving this hanging @awoehrl and thanks for contributing!
@bcodell, I found a bug in my codegen macro.
I missed that the schema_columns macro doesn't contain the anonymous_customer_id column. Also I realized, I was using customer_id, when the activity schema specs use
customer
for the customer column.Right now this means, that customer and anonymous_customer_id won't get renamed correctly if aliased.
My further question would be: