Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/readme cleanup #209

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix/readme cleanup #209

merged 2 commits into from
Oct 23, 2024

Conversation

VGabriel45
Copy link
Collaborator

No description provided.

@VGabriel45 VGabriel45 changed the title readme cleanup fix/readme cleanup Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (9937eef) to head (1a81d3d).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #209   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          14       14           
  Lines         943      943           
  Branches      256      278   +22     
=======================================
  Hits          808      808           
  Misses        120      120           
  Partials       15       15           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e7f3ab...1a81d3d. Read the comment docs.

Copy link

Changes to gas cost

Generated at commit: a2cb45bfc9a83550a7348662ccf936dd4ddf6155, compared to commit: 773943fb7bf6cd14a0dc6dcb9f513db53213d1d5

🧾 Summary (5% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
MockPaymaster 1,063,705 (+187)
HelperConfig 6,941,247 (+3,159,382)

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)
🟡 - unused-return (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L165

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ERC7739Validator.sol#L279-L309

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

@livingrockrises livingrockrises merged commit d64df5c into dev Oct 23, 2024
10 checks passed
@livingrockrises livingrockrises deleted the fix/readme branch October 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants