Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests with 6492 #179

Conversation

livingrockrises
Copy link
Contributor

No description provided.

Copy link

Changes to gas cost

Generated at commit: 44a3d59c71a566951c58aeb6ea3648523a60c1c4, compared to commit: 16273fdb3baa26e03c8b536ca3a9156197c8410a

🧾 Summary (5% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
Nexus 4,839,712 (0) execute
initializeAccount
isModuleInstalled
validateUserOp
6,426 (0)
114,400 (0)
865 (0)
13,973 (0)
0.00%
0.00%
0.00%
0.00%
46,634 (-2,767)
134,234 (-1)
1,192 (+1)
15,545 (-1)
-5.60%
-0.00%
+0.08%
-0.01%
38,126 (0)
134,300 (0)
1,168 (0)
13,973 (0)
0.00%
0.00%
0.00%
0.00%
143,204 (0)
134,300 (0)
3,212 (0)
42,860 (0)
0.00%
0.00%
0.00%
0.00%
73 (-3)
306 (-3)
328 (-3)
347 (-4)
MockPaymaster 1,093,531 (0) getHash 2,184 (0) 0.00% 2,388 (+8) +0.34% 2,483 (0) 0.00% 2,681 (0) 0.00% 16 (-1)
Bootstrap 1,930,562 (0) initNexusScoped 63,412 (0) 0.00% 83,246 (-1) -0.00% 83,312 (0) 0.00% 83,312 (0) 0.00% 306 (-3)

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (1 results) (Medium)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ERC7739Validator.sol#L176-L206

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (7f8410d) to head (c897a9b).
Report is 13 commits behind head on stacked/update-7739-base-and-safer-validators.

Additional details and impacted files
@@                              Coverage Diff                               @@
##           stacked/update-7739-base-and-safer-validators     #179   +/-   ##
==============================================================================
  Coverage                                          93.94%   93.94%           
==============================================================================
  Files                                                 14       14           
  Lines                                                727      727           
  Branches                                             165      140   -25     
==============================================================================
  Hits                                                 683      683           
  Misses                                                44       44           
Files with missing lines Coverage Δ
contracts/Nexus.sol 94.48% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8410d...c897a9b. Read the comment docs.

@filmakarov filmakarov changed the base branch from dev to stacked/update-7739-base-and-safer-validators September 23, 2024 07:16
@filmakarov filmakarov merged commit a053cd5 into stacked/update-7739-base-and-safer-validators Sep 23, 2024
10 checks passed
@filmakarov filmakarov deleted the fix/6492-1271-tests-assertions branch September 23, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants