Feat/2d nonce helpers #173
Conversation
livingrockrises
requested review from
filmakarov,
ankurdubey521,
Aboudjem and
VGabriel45
Feat/2d nonce helpers
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #173 +/- ##
=======================================
Coverage 86.40% 86.40%
=======================================
Files 14 14
Lines 905 905
Branches 266 244 -22
=======================================
Hits 782 782
Misses 109 109
Partials 14 14 Continue to review full report in Codecov by Sentry.
|
| // Todo: fix this test. instead of pranking we should send actual userOp. | ||
|
|
||
| // bytes memory expectedRevertReason = abi.encodeWithSelector( | ||
| // FailedOp.selector, | ||
| // 0, | ||
| // "AA25 invalid account nonce" | ||
| // ); | ||
|
|
||
| // vm.expectRevert(expectedRevertReason); |
There was a problem hiding this comment.
Should this be done before merge?
There was a problem hiding this comment.
fixed foundry test case.
| .connect(impersonatedEntryPoint) | ||
| .validateUserOp(userOp, userOpHash, ethers.parseEther("0.1")); | ||
| }); | ||
| // Todo: fix below test |
There was a problem hiding this comment.
hardhat one seems unrelated to testing anything nonce related but has abruptly started failing. need to check more
…function buildPackedUserOperation
| @@ -46,13 +46,13 @@ contract TestFuzz_ERC4337Account is NexusTest_Base { | |||
| vm.assume(numOps < 20); // Keep the number of operations manageable | |||
|
|
|||
| for (uint256 i = 0; i < numOps; i++) { | |||
| uint256 nonceBefore = getNonce(address(BOB_ACCOUNT), MODE_VALIDATION, address(VALIDATOR_MODULE)); | |||
| uint256 nonceBefore = getNonce(address(BOB_ACCOUNT), MODE_VALIDATION, address(VALIDATOR_MODULE), bytes3(0)); | |||
There was a problem hiding this comment.
maybe use some random batchId since it's fuzz
🤖 Slither Analysis Report 🔎Slither report
# Slither report
_This comment was automatically generated by the GitHub Actions workflow._
THIS CHECKLIST IS NOT COMPLETE. Use
locked-ether🟡 Impact: Medium
utils/RegistryBootstrap.sol#L33-L165 unused-return🟡 Impact: Medium
base/ERC7739Validator.sol#L279-L309 constable-statesImpact: Optimization
|
adds 2D nonce support by packing 3 bytes batchId into most significant 3 bytes of 24 byte (uint192) nonceKey.
no changes required in NonceLib.sol