25571 - Send queue message for reversal #1883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
commented
Feb 5, 2025
seeker25
commented
Feb 5, 2025
seeker25
commented
Feb 12, 2025
|
Requires unit tests before merging |
seeker25
requested review from
Jxio,
ochiu and
rodrigo-barraza
as code owners
seeker25
commented
Feb 14, 2025
| @@ -449,3 +450,4 @@ def _handle_invoice_refund(cls, invoice: InvoiceModel, invoice_reference: Invoic | |||
| invoice.refund_date = datetime.now(tz=timezone.utc) | |||
| invoice.refund = invoice.total | |||
| invoice.flush() | |||
| EftService().release_payment_or_reversal(invoice, TransactionStatus.REVERSED.value) | |||
There was a problem hiding this comment.
Probably need something similar to pay-queue
There was a problem hiding this comment.
Also do we send a reversal when we put an EFT invoice back to APPROVED? I think so
seeker25
commented
Feb 14, 2025
| @@ -156,7 +159,19 @@ def _process_ejv_feedback(group_batches) -> bool: # pylint:disable=too-many-loc | |||
| elif is_jv_detail: | |||
| has_errors = _process_jv_details_feedback(ejv_file, has_errors, line, receipt_number) | |||
|
|
|||
| # return invoices that were set to refunded 4 function calls deep. | |||
| refund_invoices = [ | |||
There was a problem hiding this comment.
Perhaps could hit unintended refunds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#25571
Description of changes:
Send queue message for reversal
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).