25334-EFT Statement Payment fixes (#1884)

bcgov · Jan 29, 2025 · 7352263 · 7352263
1 parent 6a08ee2
commit 7352263
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pay-api/src/pay_api/services/eft_short_names.py b/pay-api/src/pay_api/services/eft_short_names.py
@@ -78,7 +78,9 @@ def process_payment_action(cls, short_name_id: int, request: Dict):
                 case EFTPaymentActions.APPLY_CREDITS.value:
                     EftService.apply_payment_action(short_name_id, auth_account_id, statement_id)
                 case EFTPaymentActions.CANCEL.value:
-                    EftService.cancel_payment_action(short_name_id, auth_account_id, statement_id)
+                    EftService.cancel_payment_action(
+                        short_name_id=short_name_id, auth_account_id=auth_account_id, statement_id=statement_id
+                    )
                 case EFTPaymentActions.REVERSE.value:
                     EftService.reverse_payment_action(short_name_id, statement_id)
                 case _:

diff --git a/pay-api/tests/unit/api/test_eft_short_names.py b/pay-api/tests/unit/api/test_eft_short_names.py
@@ -386,8 +386,8 @@ def test_get_eft_short_name_links(session, client, jwt, app):
     assert statements_owing
     assert len(statements_owing) == 2
     assert statements_owing[0]["amountOwing"] == invoice.total
-    assert statements_owing[0]["pendingPaymentsAmount"] == 0
-    assert statements_owing[0]["pendingPaymentsCount"] == 0
+    assert statements_owing[0]["pendingPaymentsAmount"] == invoice.total
+    assert statements_owing[0]["pendingPaymentsCount"] == 1
     assert statements_owing[0]["statementId"] == statement.id
     assert statements_owing[1]["amountOwing"] == invoice2.total
     assert statements_owing[1]["pendingPaymentsAmount"] == 0