Stale payment job bug fix (#1837)

bcgov · Nov 25, 2024 · 678421b · 678421b
1 parent 0f328d2
commit 678421b
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/jobs/payment-jobs/tasks/stale_payment_task.py b/jobs/payment-jobs/tasks/stale_payment_task.py
@@ -118,6 +118,8 @@ def _verify_created_direct_pay_invoices(cls):
                 if paybc_invoice.paymentstatus in STATUS_PAID:
                     current_app.logger.debug("_update_active_transactions")
                     transaction = TransactionService.find_active_by_invoice_id(invoice.id)
+                    if not transaction or not transaction.payment_id:
+                        continue
                     payment = PaymentModel.find_by_id(transaction.payment_id)
 
                     if payment.payment_status_code == PaymentStatus.COMPLETED.value: