Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(4746): add password input components #4753

Merged
merged 1 commit into from
Jan 24, 2025
Merged

feat(4746): add password input components #4753

merged 1 commit into from
Jan 24, 2025

Conversation

junminahn
Copy link
Collaborator

No description provided.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

<>
<h1 className="font-bold text-2xl mt-4 mb-5">Password Input</h1>
<FormProvider {...methods}>
<form onSubmit={methods.handleSubmit(console.log)} autoComplete="off">
Copy link
Collaborator

@golebu2020 golebu2020 Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to avoid using console.log directly in handleSubmit and instead pass a proper callback function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@golebu2020 do you mean something like (formData) => console.log(formData)?

@junminahn junminahn merged commit ab5bedc into main Jan 24, 2025
8 of 10 checks passed
@junminahn junminahn deleted the fix/4732 branch January 24, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants