Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added params to dev to allow expansion when calling workflow; ci:… #1757

Merged
merged 39 commits into from
Jan 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
d394f24
ci: added params to dev to allow expansion when calling workflow; ci:…
cberg-aot Jan 21, 2025
51ef293
fix: added release_num & pr_num to global.env as experiment
cberg-aot Jan 21, 2025
eedf1a0
experiment: attempting to format parameters without needing oneline json
cberg-aot Jan 21, 2025
c03588f
fix: toJson needs braces aparently
cberg-aot Jan 21, 2025
2c74900
fix: toJson needs braces aparently
cberg-aot Jan 21, 2025
76483a7
fix: Removed non-single line input
cberg-aot Jan 21, 2025
770a93c
fix: Using proper needs intead of inputs
cberg-aot Jan 21, 2025
9c45aac
fix: Using proper needs intead of inputs
cberg-aot Jan 21, 2025
8e2d185
fix: Using proper needs intead of inputs
cberg-aot Jan 21, 2025
1192d83
fix: missing closing braces
cberg-aot Jan 21, 2025
1918baa
fix: missing quotes for json
cberg-aot Jan 21, 2025
33ab920
fix: attempting to generate json on values.yml
cberg-aot Jan 21, 2025
d3fa1db
fix: attempting to generate json on values.yml
cberg-aot Jan 21, 2025
194451c
fix: attempting to generate json on values.yml
cberg-aot Jan 21, 2025
2c602f6
fix: attempting to generate json on values.yml
cberg-aot Jan 21, 2025
dd5d729
fix: attempting to generate json on values.yml
cberg-aot Jan 21, 2025
52399c1
fix: attempting to generate json on values.yml
cberg-aot Jan 21, 2025
dd41473
fix: attempting to generate json on values.yml
cberg-aot Jan 22, 2025
a4ad451
fix: attempting to generate json on values.yml
cberg-aot Jan 22, 2025
5562280
fix: attempting to generate json on values.yml
cberg-aot Jan 22, 2025
ae907d0
fix: attempting to generate json on values.yml
cberg-aot Jan 22, 2025
a54ae5c
fix: attempting to generate json on values.yml
cberg-aot Jan 22, 2025
6b21091
fix: attempting to generate json on values.yml
cberg-aot Jan 22, 2025
b839cae
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 22, 2025
a75b5d3
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 22, 2025
13abeba
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 22, 2025
344edb4
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
c219794
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
7c0f307
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
b0c88af
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
408c00a
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
7de50fb
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
408d726
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
38cb340
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
022bd13
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
cb55845
Merge branch 'main' into ci/add_dynamic_param_injection_from_event
cberg-aot Jan 24, 2025
3d84f08
experiment: attmepting to inject addiontal params WITHOUT extending t…
cberg-aot Jan 24, 2025
c593d80
Merge branch 'main' into ci/add_dynamic_param_injection_from_event
cberg-aot Jan 24, 2025
481041d
Merge branch 'ci/add_dynamic_param_injection_from_event' of github.co…
cberg-aot Jan 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,23 @@ on:
required: false
type: string
default: "latest"
params:
description: 'Extra parameters to pass to helm upgrade'
default: ''
required: false
type: string
workflow_call:
inputs:
tag:
description: "Image tag to deploy"
required: false
type: string
default: "latest"
params:
description: 'Extra parameters to pass to helm upgrade'
default: ''
required: false
type: string
jobs:
deploy-dev:
name: Deploys (DEV)
Expand All @@ -38,3 +48,4 @@ jobs:
--set-json scheduler.containers[0].resources='{"limits": {"cpu": "75m", "memory": "150Mi"}, "requests": {"cpu": "25m", "memory": "50Mi"}}' \
--set-json policy.containers[0].resources='{"limits": {"cpu": "75m", "memory": "150Mi"}, "requests": {"cpu": "25m", "memory": "50Mi"}}' \
--set-json vehicles.containers[0].resources='{"limits": {"cpu": "300m", "memory": "500Mi"}, "requests": {"cpu": "200m", "memory": "400Mi"}}' \
${{ inputs.params }} \
3 changes: 3 additions & 0 deletions .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ jobs:
secrets: inherit
with:
tag: ${{ needs.vars.outputs.pr }}
params: |
--set-string global.env.pr_num='${{ needs.vars.outputs.pr }}' \
--set-string global.env.release_num='${{ needs.vars.outputs.pr }}' \

promote-images-test:
name: Promote Images - Test
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr-open.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,6 @@ jobs:
secrets: inherit
with:
tag: ${{ needs.vars.outputs.pr }}
params: |
--set-string global.env.pr_num='${{ needs.vars.outputs.pr }}' \
--set-string global.env.release_num='${{ needs.vars.outputs.pr }}' \
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ jobs:
uses: ./.github/workflows/uat.yml
secrets: inherit
with:
tag: ${{ needs.vars.outputs.release-name }}
tag: ${{ needs.vars.outputs.pr }}
params: |
--set-string global.env.pr_num='${{ needs.vars.outputs.pr }}' \
--set-string global.env.release_num='${{ needs.vars.outputs.release-name }}' \

promote-images-uat:
name: Promote Images - Uat
Expand All @@ -83,6 +86,9 @@ jobs:
secrets: inherit
with:
tag: ${{ needs.vars.outputs.pr }}
params: |
--set-string global.env.pr_num='${{ needs.vars.outputs.pr }}' \
--set-string global.env.release_num='${{ needs.vars.outputs.release-name }}' \

promote-images-prod:
name: Promote Images - Prod
Expand Down
39 changes: 26 additions & 13 deletions charts/onroutebc/values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
global:
env: {}
autoscaling: true
license: "c28f0c"
podAnnotations: |
Expand Down Expand Up @@ -34,7 +35,8 @@ frontend:
ACCESS_API_URL: "https://{{.Release.Name}}-vehicles.apps.silver.devops.gov.bc.ca"
POLICY_URL: "https://{{.Release.Name}}-policy.apps.silver.devops.gov.bc.ca"
DEPLOY_ENVIRONMENT: "{{.Values.global.vault.zone}}"
FRONTEND_PR_NUM: "{{.Values.global.pr_num}}"
PR_NUM: "{{.Values.global.env.pr_num}}"
cberg-aot marked this conversation as resolved.
Show resolved Hide resolved
RELEASE_NUM: "{{.Values.global.env.release_num}}"
config.js.template: |-
const envConfig = (() => { return {
"VITE_DEPLOY_ENVIRONMENT":"$DEPLOY_ENVIRONMENT",
Expand All @@ -43,7 +45,8 @@ frontend:
"VITE_KEYCLOAK_ISSUER_URL":"$KEYCLOAK_ISSUER_URL",
"VITE_KEYCLOAK_AUDIENCE":"$KEYCLOAK_AUDIENCE",
"VITE_SITEMINDER_LOG_OFF_URL":"$SITEMINDER_LOG_OFF_URL",
"VITE_FRONTEND_PR_NUM":"$FRONTEND_PR_NUM",
"VITE_PR_NUM":"$PR_NUM",
"VITE_RELEASE_NUM":"$RELEASE_NUM",
};
})();
containers:
Expand All @@ -64,11 +67,13 @@ frontend:
key: POLICY_URL
- name: DEPLOY_ENVIRONMENT
key: DEPLOY_ENVIRONMENT
- name: FRONTEND_PR_NUM
key: FRONTEND_PR_NUM
fromValues:
fromValues:
- name: TIMESTAMP
value: "{{ now | toString }}"
- name: PR_NUM
value: "{{ .Values.global.env.pr_num | toString }}"
- name: RELEASE_NUM
value: "{{ .Values.global.env.release_num | toString }}"
ports:
- name: http
containerPort: 3000
Expand Down Expand Up @@ -203,8 +208,10 @@ vehicles:
fromValues:
- name: TIMESTAMP
value: "{{ now | toString }}"
- name: VEHICLES_PR_NUM
value: '{{.Values.global.pr_num}}'
- name: PR_NUM
value: "{{ .Values.global.env.pr_num | toString }}"
- name: RELEASE_NUM
value: "{{ .Values.global.env.release_num | toString }}"
ports:
- name: vehicles-api
containerPort: 5000
Expand Down Expand Up @@ -340,10 +347,12 @@ dops:
- name: ACCESS_API_URL
key: ACCESS_API_URL
fromValues:
- name: DOPS_PR_NUM
value: '{{.Values.global.pr_num}}'
- name: TIMESTAMP
value: "{{ now | toString }}"
- name: PR_NUM
value: "{{ .Values.global.env.pr_num | toString }}"
- name: RELEASE_NUM
value: "{{ .Values.global.env.release_num | toString }}"
ports:
- name: dops-api
containerPort: 5001
Expand Down Expand Up @@ -474,10 +483,12 @@ scheduler:
- name: ACCESS_API_URL
key: ACCESS_API_URL
fromValues:
- name: SCHEDULER_PR_NUM
value: '{{.Values.global.pr_num}}'
- name: TIMESTAMP
value: "{{ now | toString }}"
- name: PR_NUM
value: "{{ .Values.global.env.pr_num | toString }}"
- name: RELEASE_NUM
value: "{{ .Values.global.env.release_num | toString }}"
ports:
- name: scheduler
containerPort: 5050
Expand Down Expand Up @@ -581,10 +592,12 @@ policy:
- name: FRONTEND_URL
key: FRONTEND_URL
fromValues:
- name: POLICY_PR_NUM
value: '{{.Values.global.pr_num}}'
- name: TIMESTAMP
value: "{{ now | toString }}"
- name: PR_NUM
value: "{{ .Values.global.env.pr_num | toString }}"
- name: RELEASE_NUM
value: "{{ .Values.global.env.release_num | toString }}"
ports:
- name: policy-api
containerPort: 5002
Expand Down
Loading