Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-3262 - Remove all instances of fax from frontend #1746

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Jan 16, 2025

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  • Remove all instances of fax from frontend

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Observe that all areas where fax info was originally used (eg. resend permit, permit applications, amend, void, contact details of company/my info/user details, etc) still work properly as intended

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

  • The backend needs to be changed accordingly as well, removing all instances of fax from DB and validation, just like it was removed from the frontend

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added dont merge a branch for anything that shouldn't be merged (yet or ever) and removed dont merge a branch for anything that shouldn't be merged (yet or ever) labels Jan 16, 2025
Copy link

Copy link

Copy link

Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
17.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@krishnan-aot krishnan-aot merged commit 7fe0fd0 into main Jan 21, 2025
23 of 24 checks passed
@krishnan-aot krishnan-aot deleted the ORV2-3262 branch January 21, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants