ORV2-2827 - FE: Update: Remove Applications in Progress Counter (#1600)

Co-authored-by: GlenAOT <[email protected]>
bcgov · Sep 17, 2024 · fdc89b1 · fdc89b1
1 parent c084e4a
commit fdc89b1
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 37 deletions.
diff --git a/frontend/src/common/components/tabs/TabsList.scss b/frontend/src/common/components/tabs/TabsList.scss
@@ -26,7 +26,6 @@
         opacity: 1;
         padding: 0.875rem 0;
       }
-
       &__count {
         font-size: 0.875rem;
         color: $bc-black;

diff --git a/frontend/src/common/components/tabs/TabsList.tsx b/frontend/src/common/components/tabs/TabsList.tsx
@@ -1,4 +1,4 @@
-import { Chip, Tab, Tabs } from "@mui/material";
+import { Tab, Tabs } from "@mui/material";
 
 import "./TabsList.scss";
 import { TabComponentProps } from "./types/TabComponentProps";
@@ -28,21 +28,33 @@ export const TabsList = ({
       scrollButtons="auto"
       aria-label="scrollable profile tabs"
     >
-      {componentList.map(({ label, count }, index) => {
-        return (
-          <Tab
-            key={label}
-            className="tabs-list__tab"
-            label={
-              <div className="tab">
-                <div className="tab__label">{label}</div>
-                {count ? <Chip className="tab__count" label={count} /> : null}
-              </div>
-            }
-            {...TabProps(index)}
-          />
-        );
-      })}
+      {componentList.map(
+        (
+          {
+            label,
+            // TODO remove this if we no longer need tab counters
+            // count
+          },
+          index,
+        ) => {
+          return (
+            <Tab
+              key={label}
+              className="tabs-list__tab"
+              label={
+                <div className="tab">
+                  <div className="tab__label">{label}</div>
+                  {
+                    // TODO remove this if we no longer need tab counters
+                    /* {count ? <Chip className="tab__count" label={count} /> : null} */
+                  }
+                </div>
+              }
+              {...TabProps(index)}
+            />
+          );
+        },
+      )}
     </Tabs>
   );
 };
diff --git a/frontend/src/features/permits/components/dashboard/PermitLists.tsx b/frontend/src/features/permits/components/dashboard/PermitLists.tsx
@@ -1,21 +1,14 @@
-import React, { useState } from "react";
-
+import React from "react";
 import { TabLayout } from "../../../../common/components/dashboard/TabLayout";
 import { StartApplicationAction } from "../../pages/Application/components/dashboard/StartApplicationAction";
 import { ActivePermitList } from "../permit-list/ActivePermitList";
 import { ExpiredPermitList } from "../permit-list/ExpiredPermitList";
 import { ApplicationsInProgressList } from "../permit-list/ApplicationsInProgressList";
 import { ApplicationsInReviewList } from "../permit-list/ApplicationsInReviewList";
-import { Nullable } from "../../../../common/types/common";
 import { usePermissionMatrix } from "../../../../common/authentication/PermissionMatrix";
 import { RenderIf } from "../../../../common/components/reusable/RenderIf";
 
 export const PermitLists = React.memo(() => {
-  const [applicationsInProgressCount, setApplicationsInProgressCount] =
-    useState<Nullable<number>>();
-  const handleApplicationsCountChange = (count: number) => {
-    setApplicationsInProgressCount(count);
-  };
   const tabs = [];
 
   const showApplicationsInProgressTab = usePermissionMatrix({
@@ -28,12 +21,7 @@ export const PermitLists = React.memo(() => {
   if (showApplicationsInProgressTab) {
     tabs.push({
       label: "Applications in Progress",
-      count: applicationsInProgressCount,
-      component: (
-        <ApplicationsInProgressList
-          onCountChange={handleApplicationsCountChange}
-        />
-      ),
+      component: <ApplicationsInProgressList />,
     });
   }
 

diff --git a/frontend/src/features/permits/components/permit-list/ApplicationsInProgressList.tsx b/frontend/src/features/permits/components/permit-list/ApplicationsInProgressList.tsx
@@ -42,11 +42,7 @@ const getColumns = (
   return ApplicationInProgressColumnDefinition(userRole);
 };
 
-export const ApplicationsInProgressList = ({
-  onCountChange,
-}: {
-  onCountChange: (count: number) => void;
-}) => {
+export const ApplicationsInProgressList = () => {
   const {
     applicationsInProgressQuery,
     pagination,
@@ -82,7 +78,6 @@ export const ApplicationsInProgressList = ({
       applicationsInProgress?.meta?.totalItems,
     );
     setShowAIPTable(totalCount > 0);
-    onCountChange(totalCount);
   }, [applicationsInProgress?.meta?.totalItems]);
 
   const { idirUserDetails, userDetails } = useContext(OnRouteBCContext);