small cleanup

bcgov · Mar 30, 2024 · f474b2f · f474b2f
1 parent ff4ddea
commit f474b2f
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 48 deletions.
diff --git a/frontend/src/app/common/report.ts b/frontend/src/app/common/report.ts
@@ -1,9 +1,15 @@
 import config from '../../config';
 import { ProvisionJson, SaveProvisionData } from '../components/table/reports/SelectedProvisionsTable';
 import { VariableJson } from '../components/table/reports/VariablesTable';
-// import { ProvisionData } from '../content/display/Provisions';
-import { VariableData } from '../content/display/Variables';
-import { DTR, DTRDisplayObject, DocType, DocumentDataDTO, DocumentDataObject, ProvisionGroup } from '../types/types';
+import {
+  DTR,
+  DTRDisplayObject,
+  DocType,
+  DocumentDataDTO,
+  DocumentDataObject,
+  ProvisionGroup,
+  VariableData,
+} from '../types/types';
 import { buildDTRDisplayData } from '../util/util';
 import * as api from './api';
 
@@ -42,19 +48,6 @@ export const getMandatoryProvisionsByDocTypeId = async (document_type_id: number
   return response;
 };
 
-// export const getDocumentProvisionsByDocTypeIdDtid = async (
-//   document_type_id: number,
-//   dtid: number
-// ): Promise<{ provisions: ProvisionData[]; provisionIds: number[] }> => {
-//   const url = `${config.API_BASE_URL}/report/provisions/${document_type_id}/${dtid}`;
-//   const getParameters = api.generateApiParameters(url);
-//   const response: { provisions: ProvisionData[]; provisionIds: number[] } = await api.get<{
-//     provisions: ProvisionData[];
-//     provisionIds: number[];
-//   }>(getParameters);
-//   return response;
-// };
-
 export const getDocumentVariablesByDocTypeIdDtid = async (
   document_type_id: number,
   dtid: number

diff --git a/frontend/src/app/content/display/Variables.tsx b/frontend/src/app/content/display/Variables.tsx
diff --git a/frontend/src/app/types/types.ts b/frontend/src/app/types/types.ts
@@ -348,3 +348,15 @@ export type ReducedProvisionDataObject = {
   update_timestamp: string;
   provision_group: ProvisionGroup;
 };
+
+export type VariableData = {
+  id: number;
+  variable_name: string;
+  variable_value: string;
+  help_text: string;
+  create_userid: string;
+  update_userid: string;
+  create_timestamp: string;
+  update_timestamp: string;
+  provision: Provision;
+};