Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-env): add new environment named test in the deployment pipeline #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimmypalelil
Copy link
Contributor

Description

Adding a new test environment to our deployment pipeline (github workflows) to enable better testing and validation of changes before they reach production.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The following tests were performed to verify the new environment setup:

  • Deployment pipeline execution with the new test environment
  • Environment variable configuration and isolation testing

Checklist

  • I have read the [CONTRIBUTING](https://www.notion.so/CONTRIBUTING.md) doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

This change introduces a dedicated test environment in our deployment pipeline to improve our testing capabilities. The new environment will sit between dev and prod environments, allowing for more thorough testing of features before they reach prod.

@jimmypalelil jimmypalelil force-pushed the jimmy/test-env-workflow-v2 branch 3 times, most recently from b8dc917 to 31a2a8a Compare February 6, 2025 18:38
Copy link
Contributor

@marcellmueller marcellmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Excited to have test up and running 🥇

@jimmypalelil jimmypalelil force-pushed the jimmy/test-env-workflow-v2 branch from 31a2a8a to 04ba6f5 Compare February 6, 2025 19:08
@@ -6,7 +6,7 @@ locals {
tools = "Tools"
unclass = "UnClass"
}
environment = local.env_map[lower(var.target_env)]
environment = local.env_map[lower(var.target_env) == "test" ? "dev" : lower(var.target_env)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit): If lower(var.target_env) is not a key in local.env_map, it will result in an error. I am wondering if we should do a lookup() first with a default fallback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo it shouldn't default to any env and instead error out if it can't find it in the lookup table (env_map)

@jimmypalelil jimmypalelil force-pushed the jimmy/test-env-workflow-v2 branch from 04ba6f5 to f543dc2 Compare February 6, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants