fix: pagemenu conditional section scrolling issues #322
+79
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellmueller
force-pushed
the
fix/pagemenu-conditionals
branch
2 times, most recently
from
57bcebb to
104922d
Compare
| @@ -50,7 +50,7 @@ const PageMenu: React.FC<PageMenuProps> = ({ | |||
| (section) => section.sectionIndex === Number(index), | |||
| ); | |||
| if (selectedSection) { | |||
| window.location.hash = selectedSection.link; | |||
| window.location.hash = selectedSection.href; | |||
There was a problem hiding this comment.
(bug):
-
We need to use encodeURIComponent for Safety. If href contains special characters i.e. spaces, &, ? it will prevent encoding URL issues.
-
We only need to update the hash if it actually changes. This will improve performance. We can do something like this
if (selectedSection?.href && window.location.hash !== `#${selectedSection.href}`) {
window.location.hash = encodeURIComponent(selectedSection.href);
}
| isThingsToDo ? thingsToDoRef : null, | ||
| contactRef, | ||
| ].filter((ref) => !!ref), | ||
| [description, isClosures, isThingsToDo], |
There was a problem hiding this comment.
(question): sectionRefs depends on closuresRef, siteDescriptionRef, but they are missing from dependencies array. Should that be included?
marcellmueller
force-pushed
the
fix/pagemenu-conditionals
branch
from
104922d to
fd9b140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for a couple of bugs introduced in #157, I noticed in pages without closures if you scroll down and then scroll back up the top selection in the page menu won't highlight. This is due to the conditional section ref not being in the page.