Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #628 commenting closed date clarification #636

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Jun 4, 2024

ref: #628
Clarification for the commenting close date for public.

  • Reorganize and restyle FOM public side details section.
  • Using calculated commentingClosingDate to display for "You can comment until:" with hardcoded "11:59pm" to make it clear for the public.
  • Add tooltip with info icon to popup for showing FOM validity explanation wording.

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review June 5, 2024 22:26
@ianliuwk1019 ianliuwk1019 requested review from MCatherine1994 and basilv and removed request for basilv and MCatherine1994 June 5, 2024 22:31
@MCatherine1994
Copy link
Contributor

Thanks Ian! Looks good!

@ianliuwk1019 ianliuwk1019 merged commit a08a7a7 into main Jun 10, 2024
19 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/628-commenting-closed-date-clarification branch June 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants