Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #616 Add rule for bcts fom for validityEndDate. #617

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Apr 10, 2024

#616

  • (api): adjust "validityEndDate" return calculation for BCTS FOMs.
  • (public): on Details Panel display, use "validityEndDate" from api and remove redundant "validityPeriodEndDate" calculation.
  • (public): on Public Notice Panel display, conditionally display "Validity Period" for BCTS FOMs using "commentingClosedDate"

image

I missed to create one with public notice yesterday so didn't show up in Dev, but this is the case from local:
image


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review April 10, 2024 22:43
@ianliuwk1019 ianliuwk1019 requested a review from basilv April 11, 2024 14:23
Copy link
Collaborator

@basilv basilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@ianliuwk1019 ianliuwk1019 requested a review from basilv April 11, 2024 18:33
@ianliuwk1019 ianliuwk1019 merged commit 389bcfb into main Apr 11, 2024
18 checks passed
@ianliuwk1019 ianliuwk1019 deleted the fix/validity-period-bcts-fom branch April 11, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants