Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Compliance and Enforcement Section #373

Merged
merged 20 commits into from
Feb 4, 2025
Merged

feat: Compliance and Enforcement Section #373

merged 20 commits into from
Feb 4, 2025

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Feb 1, 2025

  • New Compliance and Enforcement Section in the Authorization Details Page
  • Automatically requests data from the NRCED API
  • Data filled into a table matching the Mockup
  • Table sortable by date
  • Each record contains a link to the Natural Resource Compliance and Enforcement Database Report
  • No records message shown when there are no records.
  • E2E tests included for base content

Screenshot from 2025-02-01 15-22-54


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@popkinj popkinj requested review from dawnbcgov and kdbelair February 1, 2025 23:49
@popkinj popkinj linked an issue Feb 1, 2025 that may be closed by this pull request
3 tasks
@mishraomp
Copy link
Contributor

@popkinj could you please look at the failure, also sonar is not happy ,
image

@popkinj
Copy link
Collaborator Author

popkinj commented Feb 3, 2025

@popkinj could you please look at the failure, also sonar is not happy , image

Thanks for finding that @mishraomp .
I'm not able to reproduce the error just yet. Do you remember the steps you took?
I'll take a look at the Sonar error now. :)

@kdbelair
Copy link

kdbelair commented Feb 3, 2025

I'm not sure this is pulling the info correctly from NRCED yet. Some example facilities:

110162:
110162

108520:
108520

@popkinj
Copy link
Collaborator Author

popkinj commented Feb 3, 2025

I'm not sure this is pulling the info correctly from NRCED yet. Some example facilities:

110162: 110162

108520: 108520

That might be because those changes are in another PR. See #371

@mishraomp
Copy link
Contributor

mishraomp commented Feb 3, 2025

Hi @popkinj , I just opened the url(https://nr-epd-organics-info-373-frontend.apps.silver.devops.gov.bc.ca/authorization/110162) in browser and it prints that error in console, caddy csp needs to be updated to allow CORS request to another domain.
image

@popkinj
Copy link
Collaborator Author

popkinj commented Feb 3, 2025

Hi @popkinj , I just opened the url(https://nr-epd-organics-info-373-frontend.apps.silver.devops.gov.bc.ca/authorization/110162) in browser and it prints that error in console, caddy csp needs to be updated to allow CORS request to another domain. image

Ah yes... that makes sense.

@kdbelair
Copy link

kdbelair commented Feb 3, 2025

That might be because those changes are in another PR. See #371
@popkinj The C&E section is not showing up in that PR

Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, with a minor change request

@kdbelair
Copy link

kdbelair commented Feb 4, 2025

Noticed that we included a collapsing arrow on our mockups for C&E data for mobile. I don't think it's needed for tablet but when you have a facility with a lot of C&E results it can be a lot to scroll through on mobile. Could we implement this collapsing feature? I don't think we need to hide columns to the right as shown on mobile - that is working well as is.

C E Collapsing

@popkinj popkinj merged commit 9b91aff into main Feb 4, 2025
20 checks passed
@popkinj popkinj deleted the c-and-e-260 branch February 4, 2025 18:23
@popkinj
Copy link
Collaborator Author

popkinj commented Feb 4, 2025

Noticed that we included a collapsing arrow on our mockups for C&E data for mobile. I don't think it's needed for tablet but when you have a facility with a lot of C&E results it can be a lot to scroll through on mobile. Could we implement this collapsing feature? I don't think we need to hide columns to the right as shown on mobile - that is working well as is.

C E Collapsing

Ah... missed that. Will try and add in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth Details > Direct link to NRCED for C&E information
3 participants