-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Compliance and Enforcement Section #373
Conversation
@popkinj could you please look at the failure, also sonar is not happy , |
Thanks for finding that @mishraomp . |
That might be because those changes are in another PR. See #371 |
Hi @popkinj , I just opened the url(https://nr-epd-organics-info-373-frontend.apps.silver.devops.gov.bc.ca/authorization/110162) in browser and it prints that error in console, caddy csp needs to be updated to allow CORS request to another domain. |
Ah yes... that makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, with a minor change request
Noticed that we included a collapsing arrow on our mockups for C&E data for mobile. I don't think it's needed for tablet but when you have a facility with a lot of C&E results it can be a lot to scroll through on mobile. Could we implement this collapsing feature? I don't think we need to hide columns to the right as shown on mobile - that is working well as is. |
Ah... missed that. Will try and add in another PR. |
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: