chore: remove some of the old code which are not being used, regular …

…house keeping (#347)

backend/src/app.controller.spec.ts

@@ -1,7 +1,6 @@
 import { Test, TestingModule } from '@nestjs/testing';
 import { AppController } from './app.controller';
 import { AppService } from './app.service';
-import { ObjectStoreService } from './v1/object-store/object.store.service';
 import { AmsOracleConnectorService } from './v1/ams-oracle-connector/ams.oracle.connector.service';
 import { HttpModule } from '@nestjs/axios';
 import { OmrrResponse } from './v1/types/omrr-response';
@@ -15,7 +14,7 @@ describe('AppController', () => {
     const app: TestingModule = await Test.createTestingModule({
       imports: [HttpModule],
       controllers: [AppController],
-      providers: [AppService, ObjectStoreService, AmsOracleConnectorService],
+      providers: [AppService, AmsOracleConnectorService],
     }).compile();
     amsConnectorService = await app.resolve<AmsOracleConnectorService>(
       AmsOracleConnectorService,

backend/src/app.module.ts

@@ -8,8 +8,6 @@ import { MetricsController } from './metrics.controller';
 import { TerminusModule } from '@nestjs/terminus';
 import { HealthController } from './health.controller';
 import { ThrottlerModule } from '@nestjs/throttler';
-import { ObjectStoreModule } from './v1/object-store/object.store.module';
-import { ObjectStoreService } from './v1/object-store/object.store.service';
 import { TasksModule } from './v1/tasks/task.module';
 import { ScheduleModule } from '@nestjs/schedule';
 import { AmsOracleConnectorModule } from './v1/ams-oracle-connector/ams.oracle.connector.module';
@@ -21,23 +19,31 @@ import { HttpModule } from '@nestjs/axios';
     HttpModule,
     ConfigModule.forRoot(),
     TerminusModule,
-    ThrottlerModule.forRoot([{
-      ttl: 60000,
-      limit: 1000
-    }]),
+    ThrottlerModule.forRoot([
+      {
+        ttl: 60000,
+        limit: 1000,
+      },
+    ]),
     ScheduleModule.forRoot(),
     TasksModule,
-    ObjectStoreModule,
-    AmsOracleConnectorModule
+    AmsOracleConnectorModule,
   ],
   controllers: [AppController, MetricsController, HealthController],
-  providers: [AppService, ObjectStoreService, AmsOracleConnectorService]
+  providers: [AppService, AmsOracleConnectorService],
 })
-export class AppModule { // let's add a middleware on all routes
+export class AppModule {
+  // let's add a middleware on all routes
   configure(consumer: MiddlewareConsumer) {
-    consumer.apply(HTTPLoggerMiddleware).exclude({ path: 'metrics', method: RequestMethod.ALL }, {
-      path: 'health',
-      method: RequestMethod.ALL
-    }).forRoutes('*');
+    consumer
+      .apply(HTTPLoggerMiddleware)
+      .exclude(
+        { path: 'metrics', method: RequestMethod.ALL },
+        {
+          path: 'health',
+          method: RequestMethod.ALL,
+        },
+      )
+      .forRoutes('*');
   }
 }

backend/src/v1/tasks/task.module.ts

@@ -1,12 +1,10 @@
 import { Module } from '@nestjs/common';
 import { TasksService } from './task.service';
-import { ObjectStoreModule } from '../object-store/object.store.module';
 import { HttpModule } from '@nestjs/axios';
 import { AmsOracleConnectorModule } from '../ams-oracle-connector/ams.oracle.connector.module';
 
 @Module({
-  imports: [ObjectStoreModule, HttpModule, AmsOracleConnectorModule],
-  providers: [TasksService]
+  imports: [HttpModule, AmsOracleConnectorModule],
+  providers: [TasksService],
 })
-export class TasksModule {
-}
+export class TasksModule {}

charts/nr-epd-organics-info/templates/backend/templates/deployment.yaml

@@ -35,9 +35,6 @@ spec:
           {{- end }}
           image: "{{.Values.global.registry}}/{{.Values.global.repository}}/backend:{{ .Values.global.tag | default .Chart.AppVersion }}"
           imagePullPolicy: {{ default "IfNotPresent" .Values.backend.imagePullPolicy }}
-          envFrom:
-            - secretRef:
-                name: {{.Release.Name}}
           env:
             - name: LOG_LEVEL
               value: info