Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-686 - Refactor Animal Form and Related Components #522

Merged
merged 13 commits into from
Jul 23, 2024

Conversation

jeznorth
Copy link
Contributor

@jeznorth jeznorth commented Jul 16, 2024

Description

Refactored the 'Outcome by Animal' view and form components to provide responsive / support for viewing and managing data for this section on iPad / potentially smaller device sizes.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually Verified
  • Related cypress tests pass

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@barrfalk barrfalk changed the title CE-686 - Refactor Animal Form and Related Components - DO NOT MERGE feat: CE-686 - Refactor Animal Form and Related Components - DO NOT MERGE Jul 16, 2024
@barrfalk barrfalk marked this pull request as draft July 17, 2024 05:29
@jeznorth jeznorth requested a review from Scarlett-Truong July 17, 2024 14:04
@jeznorth jeznorth marked this pull request as ready for review July 17, 2024 14:04
@jeznorth jeznorth changed the title feat: CE-686 - Refactor Animal Form and Related Components - DO NOT MERGE feat: CE-686 - Refactor Animal Form and Related Components Jul 17, 2024
Copy link
Collaborator

@Scarlett-Truong Scarlett-Truong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeznorth I like the new layout! Tho I wish the border of each animal section is bolder, cuz the separation lines inside has the same colour and is kinda long, and may mistaken as the bottom border. That's just my thought for the design.

Functionality: there's just one issue you might need to address:

  • When you add an animal with outcome (for ex: select "Dead on arrival") -> click Save -> then click Edit -> the previous selected outcome ("Dead on arrival") is not displayed

@jeznorth
Copy link
Contributor Author

jeznorth commented Jul 22, 2024

@jeznorth I like the new layout! Tho I wish the border of each animal section is bolder, cuz the separation lines inside has the same colour and is kinda long, and may mistaken as the bottom border. That's just my thought for the design.

Functionality: there's just one issue you might need to address:

  • When you add an animal with outcome (for ex: select "Dead on arrival") -> click Save -> then click Edit -> the previous selected outcome ("Dead on arrival") is not displayed

I've reconciled the issue you noticed. Regarding the UI, it needs a significant rework. Nested forms of this complexity aren't the most user-friendly, however our "roller-skates" version here is to ensure the layout is responsive at a bare minimum.

@jeznorth jeznorth requested a review from Scarlett-Truong July 22, 2024 18:07
Copy link

@afwilcox afwilcox merged commit b2955f7 into release/pacific-spiny-lumpsucker Jul 23, 2024
15 checks passed
@afwilcox afwilcox deleted the CE-686 branch July 23, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants