-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CE-686 - Refactor Animal Form and Related Components #522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeznorth I like the new layout! Tho I wish the border of each animal section is bolder, cuz the separation lines inside has the same colour and is kinda long, and may mistaken as the bottom border. That's just my thought for the design.
Functionality: there's just one issue you might need to address:
- When you add an animal with outcome (for ex: select "Dead on arrival") -> click Save -> then click Edit -> the previous selected outcome ("Dead on arrival") is not displayed
I've reconciled the issue you noticed. Regarding the UI, it needs a significant rework. Nested forms of this complexity aren't the most user-friendly, however our "roller-skates" version here is to ensure the layout is responsive at a bare minimum. |
Quality Gate passedIssues Measures |
Description
Refactored the 'Outcome by Animal' view and form components to provide responsive / support for viewing and managing data for this section on iPad / potentially smaller device sizes.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: